[hs] RFR (L): 8010319: Implementation of JEP 181: Nest-Based Access Control

[Andrew Dinn]

On 22/05/18 16:35, Aleksey Shipilev wrote:
> I have not looked through the code, but built current valhalla/valhalla @ 41799b26a947 (nestmates)
> with x86_32 and aarch64, and ran these tests fastdebug builds on both platforms:
> 
>   test/hotspot/jtreg/runtime/Nestmates/
>     x86_32:  OK
>     aarch64: OK
> 
>   test/hotspot/jtreg/runtime/SelectionResolution/
>     x86_32:  OK
>     aarch64: OK
> 
>   test/jdk/java/lang/instrument/RedefineNestmateAttr/
>     x86_32:  OK
>     aarch64: OK
> 
>   test/jdk/java/lang/invoke/
>     x86_32:  OK-ish -- these failures seem to manifest without nestmates too
>        java/lang/invoke/condy/CondyReturnPrimitiveTest.java
> 
>          Failed. Unexpected exit from test [exit code: 134]
>        java/lang/invoke/condy/CondyWrongType.java
>          Failed. Execution failed: `main' threw exception: java.lang.Exception: failures: 5
>        java/lang/invoke/LFCaching/LFGarbageCollectedTest.java
> 
>          Error. Parse Exception: `@library' must appear before first action tag
> 
>     aarch64: FAILED
>        java/lang/invoke/SpecialInterfaceCall.java
>           http://cr.openjdk.java.net/~shade/nestmates/SpecialInterfaceCall-hs_err.log
> 
> I have not dug deeper yet, AArch64 maintainers are welcome to step in!
I'm not sure what is going on here.

A few days ago I patched the jdk/jdk dev tree with David's megapatch,
built on AArch64 and ran tier1 tests, obtaining results before and after
patching. There were some tier1 test failures which did not seem to
relate to the NestMates patch. All three of CondyReturnPrimitiveTest,
CondyWrongType and SpecialInterfaceCall passed before and after.

I will check to see the patch has been applied correctly and rerun these
tests. Aleksey, perhaps you could try again using a patched jdkdev?

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander