RFR: 8203948: Expand JVMTI callback notion of "internal threads"

Kim Barrett kim.barrett at oracle.com
Thu May 31 21:35:23 UTC 2018


> On May 30, 2018, at 10:18 PM, David Holmes <david.holmes at oracle.com> wrote:
> 
> Hi Kim,
> 
> I guess I'd like this more if NamedThread were called something like InternalThread as that captures the actual commonality of these threads (we don't really care they they have names!). But that's not your fault.

Agreed.  There don’t seem to be that many places where that naming is used, so a little nomenclature
improvement wouldn’t be a major project.  Just not something I want to take on as part of this.

> I'm still tempted to just remove the check altogether now there is only one thread we're excluding - do we really need to guard against the WatcherThread using this code?

I waffled on that, and ended up not.

> But its fine to push as-is.

Thanks.

> Thanks,
> David



More information about the hotspot-dev mailing list