RFR: AArch64: 8209415: Fix JVMTI test failure HS202

Andrew Dinn adinn at redhat.com
Tue Nov 13 17:21:30 UTC 2018


On 13/11/2018 16:40, Andrew Haley wrote:
> In a moment of madness one of us (no names, no pack drill!)  managed
> to translate from x86
> 
>     __ cmpb(Address(rbcp, 0), Bytecodes::_invokestatic);
>     __ jcc(Assembler::notEqual, L_done);
> 
> to
> 
>     __ ldrb(rscratch1, Address(rbcp, 0));
>     __ cmpw(r1, Bytecodes::_invokestatic);
>     __ br(Assembler::EQ, L_done);
> 
> Two bugs in thee lines... fixed thusly.
> 
> http://cr.openjdk.java.net/~aph/8209415/
> 
> OK for trunk and jdk8u ?
Oh my goodness, that's a doozy. Amazing that it lay there for so long
(the author seems to have checked it in in 2015 :-P )

Patch is good!

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander


More information about the hotspot-dev mailing list