RFR: 8229352: Use of an unitialized register in 32-bit ARM template interpreter
Boris Ulasevich
boris.ulasevich at bell-sw.com
Fri Aug 16 14:28:48 UTC 2019
Hi Dean,
I checked the patch is Ok on arm-hflt. If you think it is good to go I
will be happy to commit the patch.
regards,
Boris
On 13.08.2019 9:27, christoph.goettschkes at microdoc.com wrote:
> Thanks for your feedback.
>
> Here is a new webrev with the proposed change applied:
> http://cr.openjdk.java.net/~bulasevich/8229352/webrev.01/
> I tested the new changes with a subset of the hotspot tier1 JTreg test
> group.
>
> Does this look fine to you?
>
> -- Christoph
>
> "hotspot-dev" <hotspot-dev-bounces at openjdk.java.net> wrote on 2019-08-12
> 20:53:46:
>
>> From: Aleksey Shipilev <shade at redhat.com>
>> To: dean.long at oracle.com, hotspot-dev at openjdk.java.net
>> Date: 2019-08-12 20:54
>> Subject: Re: RFR: 8229352: Use of an unitialized register in 32-bit ARM
>> template interpreter
>> Sent by: "hotspot-dev" <hotspot-dev-bounces at openjdk.java.net>
>>
>> On 8/12/19 8:37 PM, dean.long at oracle.com wrote:
>>> Looks OK, but after the Condy change, the label "Long" might be better
> named
>> "NotDouble".
>>
>> +1
>>
>>> On 8/10/19 11:54 PM, christoph.goettschkes at microdoc.com wrote:
>>>> Hello,
>>>>
>>>> could someone please review the changes for
>>>> https://bugs.openjdk.java.net/browse/JDK-8229352
>>>>
>>>> webrev: http://cr.openjdk.java.net/~bulasevich/8229352/webrev.00/
>>
>> Looks good to me.
>>
>> Note: changed the typo in "uninitialized" in issue synopsis, please make
> sure
>> changeset metadata
>> reflects that.
>>
>> --
>> Thanks,
>> -Aleksey
>>
>
More information about the hotspot-dev
mailing list