RFR (S): 8235403: Further cleanup to test serviceability/sa/ClhsdbCDSCore.java

Langer, Christoph christoph.langer at sap.com
Thu Dec 5 11:06:21 UTC 2019


Hi,

please review this little test cleanup. When JDK-8234625: hs test serviceability/sa/ClhsdbCDSCore.java  fails on macOS 10.15 [0] was reviewed, there were further comments which didn't make it into the commit.

I think the check for MacOS version 10.15 should not be done, the writability check on /cores is enough. I also tried to improve some messages and added a try-with-resource around the usage of a Scanner instance.

Bug: https://bugs.openjdk.java.net/browse/JDK-8235403
Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8235403.0/

Thanks
Christoph

[0] https://bugs.openjdk.java.net/browse/JDK-8234625



More information about the hotspot-dev mailing list