RFR(S) 8199290 [TESTBUG] sun.hotspot.WhiteBox$WhiteBoxPermission is not copied

Igor Ignatyev igor.ignatyev at oracle.com
Sat Dec 14 23:40:46 UTC 2019


Hi Ioi,

looks good to me, one nit though: wouldn't it be better to use switch instead of if-elseif at ClassFileInstaller.java:L#115-119 and  JarBuilder.java:L140-144?

Thanks,
-- Igor

> On Dec 14, 2019, at 3:21 PM, Ioi Lam <ioi.lam at oracle.com> wrote:
> 
> https://bugs.openjdk.java.net/browse/JDK-8199290
> http://cr.openjdk.java.net/~iklam/jdk15/8199290-copy-whitebox-inner-cls.v01/
> 
> We have many cases of
> 
> * @run driver ClassFileInstaller sun.hotspot.WhiteBox
> 
> which should have been
> 
> * @run driver ClassFileInstaller sun.hotspot.WhiteBox sun.hotspot.WhiteBox$WhiteBoxPermission
> 
> It will be too tedious to modify these cases. So let's just fix ClassFileInstaller
> to automatically the sun.hotspot.WhiteBox$WhiteBoxPermission when WhiteBox is installed.
> 
> The JarBuilder class used by the AppCDS tests is also modified similarly.
> 
> Thanks
> - Ioi



More information about the hotspot-dev mailing list