RFR(S) 8199290 [TESTBUG] sun.hotspot.WhiteBox$WhiteBoxPermission is not copied

[Ioi Lam]

Hi Igor,

Thanks for the review. Here's an updated version that uses "switch" as 
you suggested. It also fixes the problems identified by David:

http://cr.openjdk.java.net/~iklam/jdk15/8199290-copy-whitebox-inner-cls.v02/

Thanks
- Ioi


On 12/14/19 3:40 PM, Igor Ignatyev wrote:
> Hi Ioi,
>
> looks good to me, one nit though: wouldn't it be better to use switch instead of if-elseif at ClassFileInstaller.java:L#115-119 and  JarBuilder.java:L140-144?
>
> Thanks,
> -- Igor
>
>> On Dec 14, 2019, at 3:21 PM, Ioi Lam <ioi.lam at oracle.com> wrote:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8199290
>> http://cr.openjdk.java.net/~iklam/jdk15/8199290-copy-whitebox-inner-cls.v01/
>>
>> We have many cases of
>>
>> * @run driver ClassFileInstaller sun.hotspot.WhiteBox
>>
>> which should have been
>>
>> * @run driver ClassFileInstaller sun.hotspot.WhiteBox sun.hotspot.WhiteBox$WhiteBoxPermission
>>
>> It will be too tedious to modify these cases. So let's just fix ClassFileInstaller
>> to automatically the sun.hotspot.WhiteBox$WhiteBoxPermission when WhiteBox is installed.
>>
>> The JarBuilder class used by the AppCDS tests is also modified similarly.
>>
>> Thanks
>> - Ioi