RFR (S) 8219712: code_size2 is too small on new Skylake CPUs
Baesken, Matthias
matthias.baesken at sap.com
Tue Feb 26 11:51:44 UTC 2019
Hi Ralf, looks good to me (not a Reviewer however).
I wonder - do you see the issue only in the debug builds ?
(if yes , one could maybe consider adding some constant in
" code_size2 = 36300 LP64_ONLY(+10000) "
for debug builds in the same way we do already for 64bit )
Best regards, Matthias
> Date: Tue, 26 Feb 2019 11:24:29 +0000
> From: "Schmelter, Ralf" <ralf.schmelter at sap.com>
> To: HotSpot Open Source Developers <hotspot-dev at openjdk.java.net>
> Subject: RFR (S) 8219712: code_size2 is too small on new Skylake CPUs
> Message-ID: <960a11003daa403fbc8bb841206b8853 at sap.com>
> Content-Type: text/plain; charset="us-ascii"
>
> Please review the following small patch. It increases the code_size2 constant
> by 1000 bytes, since it was too small when doing a Windows slowdebug build
> on my Skylake based system.
>
> I've increased code_isze2 in 500 bytes increments and 1000 additional bytes
> was need to avoid the assertion indicating we are exceeding the reserved
> code space.
>
> webrev:
> http://cr.openjdk.java.net/~rschmelter/webrevs/8219712/webrev.0/
> bug: https://bugs.openjdk.java.net/browse/JDK-8219712
>
> Best regards,
> Ralf
>
More information about the hotspot-dev
mailing list