RFR (S) 8219712: code_size2 is too small on new Skylake CPUs

David Holmes david.holmes at oracle.com
Tue Feb 26 13:16:38 UTC 2019


Hi Ralf,

On 26/02/2019 9:24 pm, Schmelter, Ralf wrote:
> Please review the following small patch. It increases the code_size2 constant by 1000 bytes, since it was too small when doing a Windows slowdebug build on my Skylake based system.
> 
> I've increased code_isze2 in 500 bytes increments and 1000 additional bytes was need to avoid the assertion indicating we are exceeding the reserved code space.

I agree with Matthias: can this be a DEBUG_ONLY change?

Further is the problem with 32-bit and 64-bit or only 64-bit? Your 
change affects 32-bit.

Finally what is the impact of changing this value? What exactly gets 
sized by this constant, and how might  its increase affect other things?

Thanks,
David

> webrev: http://cr.openjdk.java.net/~rschmelter/webrevs/8219712/webrev.0/
> bug: https://bugs.openjdk.java.net/browse/JDK-8219712
> 
> Best regards,
> Ralf
> 


More information about the hotspot-dev mailing list