RFR: 8219241: Provide basic virtualization related info in the hs_error file on linux/windows x86_64

Doerr, Martin martin.doerr at sap.com
Thu Feb 28 16:17:42 UTC 2019


Hi Matthias,

thanks for simplifying the assembler parts a little bit (as discussed offline).
Looks good to me. I think this is a helpful feature because virtualization can cause strange performance effects which may be hard to identify otherwise.

Best regards,
Martin


From: Baesken, Matthias
Sent: Donnerstag, 28. Februar 2019 17:05
To: 'hotspot-dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
Cc: Doerr, Martin <martin.doerr at sap.com>
Subject: RE: RFR: 8219241: Provide basic virtualization related info in the hs_error file on linux/windows x86_64

Hello,   I provided  a second version .
The  x86_64  assembler code was simplified (thanks to Martin for the hint)  ; additionally some comments were  adjusted .


http://cr.openjdk.java.net/~mbaesken/webrevs/8219241.2/


Best regards , Matthias



Hello , please review the following change.
It provides basic virtualization related information in the hs_error file on linux/windows x86_64.
We use cpuid  to get the information (detection of VMWare, Xen, KVM and HyperV is included).

Some info about how to detect the virtualization info can be found here :
https://kb.vmware.com/s/article/1009458



(it is VMware related but can be applied for other virtualization technologies as well)


An overview of the ID strings can be found here as well :

https://en.wikipedia.org/wiki/CPUID
The following are known ID strings from virtual machines: ...



bug/webrev :

https://bugs.openjdk.java.net/browse/JDK-8219241

http://cr.openjdk.java.net/~mbaesken/webrevs/8219241.1/



Thanks, Matthias


More information about the hotspot-dev mailing list