RFR: 8219241: Provide basic virtualization related info in the hs_error file on linux/windows x86_64
David Holmes
david.holmes at oracle.com
Thu Feb 28 21:48:48 UTC 2019
Hi Matthias,
Combining this with 8219746 I have to insist that we use a nice clean
OS-CPU abstraction for dealing with this and get rid of the platform
ifdefs in os::Linux::print_virtualization_info. What you've added in
VM_Version would seem to be the right kind of platform specific
functionality and it seems to me that you could get rid of
os::Linux::print_virtualization_info and just use
VM_Version::print_detected_virtualization in its place.
Thanks,
David
On 1/03/2019 2:04 am, Baesken, Matthias wrote:
> Hello, I provided a second version .
> The x86_64 assembler code was simplified (thanks to Martin for the hint) ; additionally some comments were adjusted .
>
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8219241.2/
>
>
> Best regards , Matthias
>
>
>
> Hello , please review the following change.
> It provides basic virtualization related information in the hs_error file on linux/windows x86_64.
> We use cpuid to get the information (detection of VMWare, Xen, KVM and HyperV is included).
>
> Some info about how to detect the virtualization info can be found here :
> https://kb.vmware.com/s/article/1009458
>
>
>
> (it is VMware related but can be applied for other virtualization technologies as well)
>
>
> An overview of the ID strings can be found here as well :
>
> https://en.wikipedia.org/wiki/CPUID
> The following are known ID strings from virtual machines: ...
>
>
>
> bug/webrev :
>
> https://bugs.openjdk.java.net/browse/JDK-8219241
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8219241.1/
>
>
>
> Thanks, Matthias
>
More information about the hotspot-dev
mailing list