RFR (XS): 8216366: Add rationale to PER_CPU_SHARES define

Severin Gehwolf sgehwolf at redhat.com
Tue Jan 8 15:15:41 UTC 2019


On Tue, 2019-01-08 at 08:31 -0500, Bob Vandette wrote:
> I don’t know how folks feel about embedding possible bit-rotting URLs in the sources but
> it looks good to me.  

I've considered that. Then concluded that URLs might be useful even if
they bitrot (in times like wayback machine and such).

> Thanks for doing this.

Thanks for the review Bob!

Any Reviewers care to comment on this? Can I consider this a trivial
change?

Thanks,
Severin

> Bob.
> 
> 
> > On Jan 8, 2019, at 8:22 AM, Severin Gehwolf <sgehwolf at redhat.com>
> > wrote:
> > 
> > Hi,
> > 
> > Could I get reviews for this comment-only change, please. It's
> > meant to
> > clarify as to why a magic number of 1024 is being used for
> > PER_CPU_SHARES define for the JVM container support.
> > 
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8216366
> > webrev: 
> > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8216366/webrev.01/
> > 
> > More info is in this thread:
> > 
http://mail.openjdk.java.net/pipermail/hotspot-dev/2019-January/036087.html
> > 
> > Thanks,
> > Severin
> > 
> 
> 



More information about the hotspot-dev mailing list