RFR(XXS) 8217785: Padding ParallelTaskTerminator::_offerred_termination variable

zgu at redhat.com zgu at redhat.com
Mon Jan 28 19:48:32 UTC 2019


Thanks, Aleksey!

Could you also help reviewing following two related changes?

[1] https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2019-January
/024702.html

[2] https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2019-January
/024707.html

-Zhengyu


On Mon, 2019-01-28 at 20:38 +0100, Aleksey Shipilev wrote:
> On 1/28/19 8:20 PM, zgu at redhat.com wrote:
> > Hi,
> > 
> > Could I have reviews for this small enhancement, that pads
> > _offer_termination variable into a separate cacheline? cause the
> > variable may be highly contended during task termination.
> > 
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8217785
> > Webrev: http://cr.openjdk.java.net/~zgu/JDK-8217785/webrev.00/
> 
> This looks fine to me.
> 
> -Aleksey
> 
> 


More information about the hotspot-dev mailing list