RFR(XXS) 8217785: Padding ParallelTaskTerminator::_offered_termination variable

Thomas Schatzl thomas.schatzl at oracle.com
Tue Jan 29 09:56:41 UTC 2019


Hi,

On Mon, 2019-01-28 at 14:20 -0500, zgu at redhat.com wrote:
> Hi,
> 
> Could I have reviews for this small enhancement, that pads
> _offer_termination variable into a separate cacheline? cause the
> variable may be highly contended during task termination.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8217785
> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8217785/webrev.00/
> 
> Test:
>   hotspot_gc (+/- UseOWSTTaskTerminator) on Linux x64 (fastdebug and
> release)
> 

  looks good.

Please make sure that the title in the push message is correct :)
(s/offerred/offered/ - I fixed it in the CR title).

Thanks,
  Thomas




More information about the hotspot-dev mailing list