RFR (S) 8217994: os::print_hex_dump should be more resilient against unreadable memory

Aleksey Shipilev shade at redhat.com
Wed Jan 30 12:31:36 UTC 2019


On 1/30/19 1:10 PM, Thomas Stüfe wrote:
> Or, since this thing keeps coming up, add a helper to outputStream:
> 
> +void outputStream::put(char ch, int repeat_count) {
> + for (int i = 0; i < repeat_count; i ++) {
> + put(ch);
> + }
> +}
> +
> 
> st->put('?', 2*unitsize);

No. Let's stop here:
 http://cr.openjdk.java.net/~shade/8217994/webrev.02/

There are thousand ways to do things, and there are only 8 work hours per day.
Current patch with unusual format specifier is already good, to my taste.

-Aleksey



More information about the hotspot-dev mailing list