RFR: 8226816: add UserHandler calls to event log

Baesken, Matthias matthias.baesken at sap.com
Fri Jul 5 12:21:57 UTC 2019


Hello David , here is another webrev  with  get_signal_name / get_signal_number   moved to os.cpp :

http://cr.openjdk.java.net/~mbaesken/webrevs/8226816.1/


Best regards, Matthias

> 
> On 4/07/2019 11:06 pm, Baesken, Matthias wrote:
> > Hi David,  thanks for looking into this .
> >
> >>
> >> If you add this then we don't need distinct POSIX and non-POSIX versions
> >> - the existing os::Posix::get_signal_name etc could all be hoisted into
> >> os.cpp and the os class - no?
> >>
> >
> > Should I go for this ?
> > The coding is still a little different   (e.g. is_valid_signal (.. ) call  in os_posix )
> but I think it could be done without much trouble (maybe with a few small
> ifdefs ) .
> 
> I think it's worth trying it.
> 
> I have to apologize in advance though as I'm about to disappear on two
> weeks vacation so may not be able to follow through on this.
> 
> Thanks,
> David
> 



More information about the hotspot-dev mailing list