RFR: 8227054: ServiceThread needs to know about all OopStorage objects
Mandy Chung
mandy.chung at oracle.com
Fri Jul 26 17:31:52 UTC 2019
On 7/26/19 9:38 AM, Kim Barrett wrote:
>> On Jul 26, 2019, at 12:06 PM, Mandy Chung <mandy.chung at oracle.com> wrote:
>>
>> Hi Kim,
>>
>> A passing comment (not a review):
>> 40 // For serviceability agent.
>>
>>
>>
>> ServiceThread is used for serviceability such as JVM TI and M&M but not serviceability agent.
> The comment is correct. The variables and their initialization that the comment
> applies to are referred to by the serviceability agent. The ServiceThread doesn’t
> care about these at all. Indeed, with these changes, nothing in the VM cares about
> them anymore, and I was originally going to delete them.
>
I see what you meant. It might be clearer to say these fields are read
by serviceability agent.
src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/JNIHandles.java
Mandy
More information about the hotspot-dev
mailing list