RFR: 8227054: ServiceThread needs to know about all OopStorage objects

[Kim Barrett]

> On Jul 26, 2019, at 1:31 PM, Mandy Chung <mandy.chung at oracle.com> wrote:
> 
> 
> 
> On 7/26/19 9:38 AM, Kim Barrett wrote:
>>> On Jul 26, 2019, at 12:06 PM, Mandy Chung <mandy.chung at oracle.com> wrote:
>>> 
>>> Hi Kim,
>>> 
>>> A passing comment (not a review):
>>>   40   // For serviceability agent.
>>> 
>>> 
>>> 
>>> ServiceThread is used for serviceability such as JVM TI and M&M but not serviceability agent.
>> The comment is correct.  The variables and their initialization that the comment
>> applies to are referred to by the serviceability agent.  The ServiceThread doesn’t
>> care about these at all.  Indeed, with these changes, nothing in the VM cares about
>> them anymore, and I was originally going to delete them.
>> 
> 
> I see what you meant.  It might be clearer to say these fields are read by serviceability agent.
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/JNIHandles.java
> 
> Mandy

I changed the comment to say “These are used by the serviceability agent.”