: PING: RFR(s): 8224600: Provide VM.events command

[Thomas Stüfe]

Hi Matthias,

thanks for the review.

See my answer to David:

https://mail.openjdk.java.net/pipermail/hotspot-dev/2019-June/038344.html

>* > Please note that I only tested the selection feature to work, but I see
*>* > little value in testing any permutation of the "log" option. Would just
*>* > make the test larger and more brittle and burn test machine time without
*>* > any real value.*

Cheers, Thomas



On Tue, Jun 4, 2019 at 10:04 AM Baesken, Matthias <matthias.baesken at sap.com>
wrote:

>
> Hello,  shouldn't you check as well   in
>
> test/hotspot/jtreg/serviceability/dcmd/vm/EventsTest.java
>
>    public void run_all(CommandExecutor executor) {
>     ...
>    }
>
> for the event log parts
>
> "Classes redefined"
>
> and
>
> "Internal exceptions"    ?
>
>
> Otherwise looks good,  no new webrev needed .
>
>
> Best regards, Matthias
>
>
>
> > Date: Mon, 3 Jun 2019 10:19:38 +0200
> > From: Thomas St?fe <thomas.stuefe at gmail.com>
> > To: HotSpot Open Source Developers <hotspot-dev at openjdk.java.net>
> > Subject: PING: RFR(s): 8224600: Provide VM.events command
> > Message-ID:
> >       <CAA-vtUxVOJxFtvG-42sC13N-6+RNWfWbmGnQ6a=jF-
> > _rxPekyw at mail.gmail.com>
> > Content-Type: text/plain; charset="UTF-8"
> >
> > Hi all,
> >
> > may I please have a second reviewer for this. It is a rather small
> addition
> > to add a new jcmd to print event logs.
> >
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8224601
> > Latest webrev:
> > http://cr.openjdk.java.net/~stuefe/webrevs/vm.events/webrev.01/webrev
> > /
> >
> > Thank you, Thomas
> >
> > On Thu, May 23, 2019 at 9:51 PM Thomas St?fe <thomas.stuefe at gmail.com>
> > wrote:
> >
> > > Hi all,
> > >
> > > May I please have reviews for the following addition to jcmd.
> > >
> > > Bug: https://bugs.openjdk.java.net/browse/JDK-8224600
> > > CSR: https://bugs.openjdk.java.net/browse/JDK-8224601
> > > webrev:
> > >
> > http://cr.openjdk.java.net/~stuefe/webrevs/vm.events/webrev.00/webrev
> > /index.html
> > >
> > > This adds a new command, "VM.events", which can be used to display VM
> > > event logs. Please see linked CSR for details.
> > >
> > > The CSR itself is not yet approved but already in proposed state.
> > >
> > > Thanks, Thomas
> > >
> >
>
>