: PING: RFR(s): 8224600: Provide VM.events command

[Baesken, Matthias]

Hello,  shouldn't you check as well   in

test/hotspot/jtreg/serviceability/dcmd/vm/EventsTest.java

   public void run_all(CommandExecutor executor) {
    ...
   }

for the event log parts 

"Classes redefined"

and

"Internal exceptions"    ?


Otherwise looks good,  no new webrev needed .


Best regards, Matthias



> Date: Mon, 3 Jun 2019 10:19:38 +0200
> From: Thomas St?fe <thomas.stuefe at gmail.com>
> To: HotSpot Open Source Developers <hotspot-dev at openjdk.java.net>
> Subject: PING: RFR(s): 8224600: Provide VM.events command
> Message-ID:
> 	<CAA-vtUxVOJxFtvG-42sC13N-6+RNWfWbmGnQ6a=jF-
> _rxPekyw at mail.gmail.com>
> Content-Type: text/plain; charset="UTF-8"
> 
> Hi all,
> 
> may I please have a second reviewer for this. It is a rather small addition
> to add a new jcmd to print event logs.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8224601
> Latest webrev:
> http://cr.openjdk.java.net/~stuefe/webrevs/vm.events/webrev.01/webrev
> /
> 
> Thank you, Thomas
> 
> On Thu, May 23, 2019 at 9:51 PM Thomas St?fe <thomas.stuefe at gmail.com>
> wrote:
> 
> > Hi all,
> >
> > May I please have reviews for the following addition to jcmd.
> >
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8224600
> > CSR: https://bugs.openjdk.java.net/browse/JDK-8224601
> > webrev:
> >
> http://cr.openjdk.java.net/~stuefe/webrevs/vm.events/webrev.00/webrev
> /index.html
> >
> > This adds a new command, "VM.events", which can be used to display VM
> > event logs. Please see linked CSR for details.
> >
> > The CSR itself is not yet approved but already in proposed state.
> >
> > Thanks, Thomas
> >
>