RFR [XS]: 8224958: add os::dll_load calls to event log

Thomas Stüfe thomas.stuefe at gmail.com
Tue Jun 4 12:13:57 UTC 2019


Hi Matthias,

this is useful. Can you please

- add the dlerror output to the log (where easily available)
- I see an existing issue on some platforms where the return value of
dlerror() is copied without null check first. dlerror() may return NULL.
Can you please add null checks where needed?

Thanks!

..Thomas

On Tue, Jun 4, 2019 at 2:03 PM Baesken, Matthias <matthias.baesken at sap.com>
wrote:

> Hello, please review  the following small  change .
>
> The current event log holds the last n events of various interesting
> operations.
> It is printed in the hs_err file and helps to analyze various issues /
> bugs .
> I would like to add shared library loading operations (os::dll_load) to
> the events added by calling Events::log.
>
> Bug/webrev :
>
> https://bugs.openjdk.java.net/browse/JDK-8224958
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8224958.0/
>
>
> Best regards, Matthias
>
>


More information about the hotspot-dev mailing list