RFR [XS]: 8224958: add os::dll_load calls to event log

[Baesken, Matthias]

Hi Thomas thanks for the input !


  *   . dlerror() may return NULL

Sure I can add this , makes sense to check for NULL !


Looks like there are a few other   places   of dlerror usage where a NULL check is missing , one example  :

jdk/src/jdk.crypto.cryptoki/unix/native/libj2pkcs11/p11_md.c

108        systemErrorMessage = dlerror();
109        exceptionMessage = (char *) malloc(sizeof(char) * (strlen(systemErrorMessage) + strlen(libraryNameStr) + 1));




  *   add the dlerror output to the log (where easily available)

My “fear”  was the messages might get a bit too long and eat up too much space ,  do you think it is fine ?

Best regards, Matthias


From: Thomas Stüfe <thomas.stuefe at gmail.com>
Sent: Dienstag, 4. Juni 2019 14:14
To: Baesken, Matthias <matthias.baesken at sap.com>
Cc: hotspot-dev at openjdk.java.net
Subject: Re: RFR [XS]: 8224958: add os::dll_load calls to event log

Hi Matthias,

this is useful. Can you please

- add the dlerror output to the log (where easily available)
- I see an existing issue on some platforms where the return value of dlerror() is copied without null check first. dlerror() may return NULL. Can you please add null checks where needed?

Thanks!

..Thomas

On Tue, Jun 4, 2019 at 2:03 PM Baesken, Matthias <matthias.baesken at sap.com<mailto:matthias.baesken at sap.com>> wrote:
Hello, please review  the following small  change .

The current event log holds the last n events of various interesting operations.
It is printed in the hs_err file and helps to analyze various issues / bugs .
I would like to add shared library loading operations (os::dll_load) to the events added by calling Events::log.

Bug/webrev :

https://bugs.openjdk.java.net/browse/JDK-8224958

http://cr.openjdk.java.net/~mbaesken/webrevs/8224958.0/


Best regards, Matthias