deoptimization.cpp Events::log / Events::log_deopt_message - was : RE: RFR: 8224221: add memprotect calls to event log

[Vladimir Kozlov]

Got it. Yes, I agree that they should be also in deopt log.

Thanks,
Vladimir

On 6/4/19 1:27 AM, Baesken, Matthias wrote:
> Hi Vladimir ,  sure  the  log_deopt_message() is used  for the event-logging and the events are later shown  in the hs_err file  .
> 
> However my question was :  in  deoptimization.cpp   we have  ***both*** calls  to   Events::log   and     Events::log_deopt_message   .
> 
>    // Log a message
>    Events::log(thread, "Uncommon trap: trap_request=" PTR32_FORMAT " fr.pc=" INTPTR_FORMAT " relative=" INTPTR_FORMAT,
>                trap_request, p2i(fr.pc()), fr.pc() - fr.cb()->code_begin());
> 
> Events::log(thread, "DEOPT PACKING pc=" INTPTR_FORMAT " sp=" INTPTR_FORMAT, p2i(fr.pc()), p2i(fr.sp()));
> 
> 
>      // Log a message
>      Events::log_deopt_message(thread, "Uncommon trap: reason=%s action=%s pc=" INTPTR_FORMAT " method=%s @ %d %s",
>                                trap_reason_name(reason), trap_action_name(action), p2i(fr.pc()),
>                                trap_method->name_and_sig_as_C_string(), trap_bci, nm->compiler_name());
> 
>      
> 
> 
> I think they  all  should  call  Events::log_deopt_message ,  so that they go into the  same event log part  that is collecting the de-opt  event messages .
> 
> Deoptimization events (19 events):       < the deoptimization part >
>    ..
> 
> Events (20 events):      < the "general"  events part >
>   ...
> 
> 
> 
> Best regards, Matthias
> 
> 
> 
>> From: Vladimir Kozlov <vladimir.kozlov at oracle.com>
>> To: "Baesken, Matthias" <matthias.baesken at sap.com>,
>> 	"'hotspot-dev at openjdk.java.net'" <hotspot-
>> dev at openjdk.java.net>,
>> 	"hotspot-compiler-dev at openjdk.java.net"
>> 	<hotspot-compiler-dev at openjdk.java.net>
>> Subject: Re: deoptimization.cpp Events::log /
>> 	Events::log_deopt_message - was : RE: RFR: 8224221: add
>> memprotect
>> 	calls to event log
>> Message-ID: <fdf79470-0507-f8d0-60d8-184618ba12b6 at oracle.com>
>> Content-Type: text/plain; charset=utf-8; format=flowed
>>
>> log_deopt_message() is used for crashes to list these events in hs_err file:
>>
>> https://bugs.openjdk.java.net/browse/JDK-7141200
>>
>> Vladimir
>>
>> On 5/23/19 4:16 AM, Baesken, Matthias wrote:
>>> Hello,  could please someone comment on the  Events::log /
>> Events::log_deopt_message  calls  in  deoptimization.cpp  , should they
>> better all
>>> Go to the  deopt  log ( Events::log_deopt_message   ) ?
>>>
>>> Best regards, Matthias
>