RFR: 8225429: Regression in disassembly quality

[Andrew Haley]

Hi,

On 6/7/19 12:16 AM, David Holmes wrote:

> On 7/06/2019 1:19 am, Andrew Haley wrote:
>> In a debug build, if you printed a disassembled method, you used to
>> get a lot of information about a method. Now, you just get raw
>> disassembly. This patch restores the status quo ante,
>>
>> http://cr.openjdk.java.net/~aph/8225429-1/
> 
> src/hotspot/share/asm/codeBuffer.hpp
> 
>        _collect_comments = ( PrintAssembly
>                           || PrintStubCode
>                           || PrintMethodHandleStubs
>                           || PrintInterpreter
>                           || PrintSignatureHandlers
> +                        || UnlockDiagnosticVMOptions
>                            );
> 
> Would it be better to explicitly enable this in debug, using 
> trueInDebug, versus using an otherwise unrelated flag that happens to be 
> "true in debug"? Or is there also some reason to turn this on in product 
> when UnlockDiagnosticVMOptions is used?

Exactly. If we can get comments enabled in product builds this will
just work.

-- 
Andrew Haley
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671