RFR: 8225429: Regression in disassembly quality

[Andrew Haley]

On 6/7/19 9:16 AM, Andrew Haley wrote:
>> Would it be better to explicitly enable this in debug, using 
>> trueInDebug, versus using an otherwise unrelated flag that happens to be 
>> "true in debug"? Or is there also some reason to turn this on in product 
>> when UnlockDiagnosticVMOptions is used?
> Exactly. If we can get comments enabled in product builds this will
> just work.

And in addition, I don't think that UnlockDiagnosticVMOptions is an unrelated
flag. But we can discuss exact flag names and what colour we should paint it
later. I'm not going to forget about getting debug assembly fixed properly,
but in the meantime HotSpot debugging is seriously broken, and this is enough
for us to get our work done.

-- 
Andrew Haley
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671