RFR[XS]: 8220353: [TESTBUG] TestRegisterRestoring uses SafepointALot without UnlockDiagnosticVMOptions
Tobias Hartmann
tobias.hartmann at oracle.com
Fri Mar 8 13:10:41 UTC 2019
Hi Severin,
yes, SafepointALot was made diagnostic by 8219584 [1]. The fix looks good and trivial to me but I
think you can then remove -XX:+IgnoreUnrecognizedVMOptions which was there to ignore SafepointALot
in product builds when it still was a debug option.
Best regards,
Tobias
[1] http://hg.openjdk.java.net/jdk/jdk/rev/feea57b38a1c#l3.7
On 08.03.19 14:03, Severin Gehwolf wrote:
> Hi,
>
> Currently one test in tier1 tests fails for me: TestRegisterRestoring.
> It fails because its using -XX:+SafepointALot without
> -XX:+UnlockDiagnosticVMOptions. I assume SafepointALot being diagnostic
> might have been a recent change. Not sure. Anyway, here is a fix:
>
> http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8220353/01/webrev/
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8220353
>
> Testing: Test fails prior this fix. Passes after.
>
> I intend to push this change under the trivial rules, OK?
>
> Thoughts?
>
> Thanks,
> Severin
>
>
More information about the hotspot-dev
mailing list