RFR[XS]: 8220353: [TESTBUG] TestRegisterRestoring uses SafepointALot without UnlockDiagnosticVMOptions

[Severin Gehwolf]

Hi Tobias,

On Fri, 2019-03-08 at 14:10 +0100, Tobias Hartmann wrote:
> Hi Severin,
> 
> yes, SafepointALot was made diagnostic by 8219584 [1]. The fix looks good and trivial to me but I
> think you can then remove -XX:+IgnoreUnrecognizedVMOptions which was there to ignore SafepointALot
> in product builds when it still was a debug option.

Thanks. I've removed -XX:+IgnoreUnrecognizedVMOptions:
http://hg.openjdk.java.net/jdk/jdk/rev/65a9f034954f

Test passes for me without it and added UnlockDiagnosticVMOptions.

Thanks,
Severin

> Best regards,
> Tobias
> 
> [1] http://hg.openjdk.java.net/jdk/jdk/rev/feea57b38a1c#l3.7
> 
> On 08.03.19 14:03, Severin Gehwolf wrote:
> > Hi,
> > 
> > Currently one test in tier1 tests fails for me: TestRegisterRestoring.
> > It fails because its using -XX:+SafepointALot without
> > -XX:+UnlockDiagnosticVMOptions. I assume SafepointALot being diagnostic
> > might have been a recent change. Not sure. Anyway, here is a fix:
> > 
> > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8220353/01/webrev/
> > 
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8220353
> > 
> > Testing: Test fails prior this fix. Passes after.
> > 
> > I intend to push this change under the trivial rules, OK?
> > 
> > Thoughts?
> > 
> > Thanks,
> > Severin
> > 
> >