RFR[XS]: 8220353: [TESTBUG] TestRegisterRestoring uses SafepointALot without UnlockDiagnosticVMOptions

[Severin Gehwolf]

Hi Aleksey,

On Fri, 2019-03-08 at 14:13 +0100, Aleksey Shipilev wrote:
> On 3/8/19 2:03 PM, Severin Gehwolf wrote:
> > Currently one test in tier1 tests fails for me: TestRegisterRestoring.
> > It fails because its using -XX:+SafepointALot without
> > -XX:+UnlockDiagnosticVMOptions. I assume SafepointALot being diagnostic
> > might have been a recent change. Not sure.
> 
> It was introduced by recent push of JDK-8219584, I linked the bug.
> 
> I see other tests that use SafepointAtLot without unlocking it, are those failing too?
>  runtime/handshake/HandshakeTransitionTest.java
> 
> It has @requires debug, which probably unlocks the flag automatically.

These tests which all use SavepointALot have UnlockDiagnosticVMOptions
already:

test/hotspot/jtreg/runtime/handshake/HandshakeTransitionTest.java
test/hotspot/jtreg/compiler/c2/Test8004741.java
test/hotspot/jtreg/compiler/runtime/Test7196199.java
test/hotspot/jtreg/runtime/Safepoint/TestAbortVMOnSafepointTimeout.java

> > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8220353/01/webrev/
> 
> Looks good and trivial to me.

Thanks! Pushed:
http://hg.openjdk.java.net/jdk/jdk/rev/65a9f034954f

Cheers,
Severin