RFR[XS]: 8220353: [TESTBUG] TestRegisterRestoring uses SafepointALot without UnlockDiagnosticVMOptions

Aleksey Shipilev shade at redhat.com
Fri Mar 8 13:13:05 UTC 2019


On 3/8/19 2:03 PM, Severin Gehwolf wrote:
> Currently one test in tier1 tests fails for me: TestRegisterRestoring.
> It fails because its using -XX:+SafepointALot without
> -XX:+UnlockDiagnosticVMOptions. I assume SafepointALot being diagnostic
> might have been a recent change. Not sure.

It was introduced by recent push of JDK-8219584, I linked the bug.

I see other tests that use SafepointAtLot without unlocking it, are those failing too?
 runtime/handshake/HandshakeTransitionTest.java

It has @requires debug, which probably unlocks the flag automatically.

> http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8220353/01/webrev/

Looks good and trivial to me.

> I intend to push this change under the trivial rules, OK?

Yes.

-Aleksey



More information about the hotspot-dev mailing list