RFR [XS] : 8220781: linux-s390 : os::get_summary_cpu_info gives bad output

Schmidt, Lutz lutz.schmidt at sap.com
Tue Mar 19 10:35:02 UTC 2019


Hi Matthias,
you change looks good (and trivial). Please note: I’m not a reviewer!
Too bad we can’t print the hostname in PRODUCT builds. It has proven helpful when analyzing multiple hs_err* files (from distributed systems) in parallel.
Thanks,
Lutz

From: "Baesken, Matthias" <matthias.baesken at sap.com>
Date: Monday, 18. March 2019 at 16:41
To: "hotspot-dev at openjdk.java.net" <hotspot-dev at openjdk.java.net>
Cc: Lutz Schmidt <lutz.schmidt at sap.com>
Subject: RFR [XS] : 8220781: linux-s390 : os::get_summary_cpu_info gives bad output

Hello,  please review the following small fix.
Issue :  currently  the  Host:    information line in the hs_err file  looks strange  on  linux s390x .
Here is an example :

Host: s    : 6, 6 cores, 11G, SUSE Linux Enterprise Server 11 (s390x)

The strange  output  after Host:    (“s    : 6”)    is caused  by  os::get_summary_cpu_info  ; it scans for the string “processor”   and runs into    the second line   of the  file :

more /proc/cpuinfo
vendor_id       : IBM/S390
# processors    : 6

This leads to  “s    : 6” .
Instead  we can get   the  “machine”  ID -number  which is available  in the  /proc/cpuinfo   file . This can be used to look up the machine+related processor model .

Another question  I had when looking into the   issue   -  why is the  hostname  after “Host:”    only printed in the non-product case ?
It could be also helpful  in the product build as well .



Bug/webrev :

https://bugs.openjdk.java.net/browse/JDK-8220781

http://cr.openjdk.java.net/~mbaesken/webrevs/8220781.0/



Thanks, Matthias




More information about the hotspot-dev mailing list