RFR 8157372: C2: Node::cmp() should return bool

[Derek Thomson]

Thanks Vladimir,

When I follow those instructions for testing I get a failure with the
defpath extension. I'm going to ask JC Beyler here, too. I can't figure it
out - it looks like it uses @command to me. I'm using Mercurial 4.7.2

*** failed to import extension defpath from
/usr/local/google/home/dthomson/Downloads/defpath.py: missing attributes:
norepo, optionalrepo, inferrepo
*** (use @command decorator to register 'defpath')


On Tue, Mar 19, 2019 at 1:39 PM Vladimir Kozlov <vladimir.kozlov at oracle.com>
wrote:

> Hi Derek,
>
> On 3/19/19 11:08 AM, Derek Thomson wrote:
> > Changed uint to bool throughout. Could someone review my change please?
>
> Looks good to me.
>
> > Also, what tests should I run to validate this?
>
> You can use submit repo to do build and tier1 testing on all platforms
> supported by Oracle:
> https://wiki.openjdk.java.net/display/Build/Submit+Repo
>
> >
> > Webrev: http://cr.openjdk.java.net/~jcbeyler/8157372/webrev.00/
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8157372
> >
>
> Thanks,
> Vladimir
>