[13] RFR(S): 8223885: hs_err and replay file may contain garbage when overwriting existing file

[Thomas Stüfe]

On Thu, May 16, 2019 at 8:54 AM Tobias Hartmann <tobias.hartmann at oracle.com>
wrote:

> Hi Thomas,
>
> On 16.05.19 07:22, Thomas Stüfe wrote:
> > Again, sorry for that.
> >
> > I found that CDT (I use Eclipse CDT) call hierarchy was lying to me and
> did not show the second call
> > to prepate_log_file in VMError::report_and_die(), so I missed the fact
> that this affects compiler
> > replay files. I am upset by this, since CDT is my main work tool
> nowadays.
>
> I've recently switched from Eclipse to CLion which seems to be much better
> at code analysis and also
> shows both usages in the call hierarchy.
>

A colleague just showed me that tree nodes of the call tree pointing inside
the same function are merged. Now I am relieved a bit. The problem was in
front of the screen :)

Yes, I hear good things about CLion. How is speed for you? Last time I
tested opening a call hierarchy took a lot of time, with the frames
basically trickling in. In CDT call hierarchy is instantaneous.


>
> > Also confusing is that the submit tests went thru fine. So I guess the
> replay compiler test is not
> > part of the submit test suite.
>
> Yes, unfortunately it's not executed at tier1.
>
> Best regards,
> Tobias
>

Cheers, Thomas