RFR(s): 8224600: Provide VM.events command

[Thomas Stüfe]

Hi Yumin,


On Fri, May 24, 2019 at 5:50 AM yumin qi <yumin.qi at gmail.com> wrote:

> HI, Thomas
>
>   It looks good to me.
>

Thank you!


> One question of the test, could it be including test for 'max' = some
> number other than '-1'.
>

Hmm, I'd rather not.

This would require more intricate output parsing and make the test more
complicated and brittle and increase test time while gaining not much:

The point of this tests is to test that the command exist, that jcmd can
attach, invoke the command and get some kind of reasonable reply without
the VM to crash or hang. I usually test command variations only if they
cover sufficiently different coding, e.g. use different locking mechanisms
(see e.g. PrintMetaspaceDcmd.java). But here, I do not expect this code to
change often so I think a regression test is not needed. In the future,
should this parameter break, we can rethink this.


>  (I am Not a Reviewer).
>

Thanks anyway.

Cheers, Thomas


>
> Thanks
> Yumin
>
> On Thu, May 23, 2019 at 12:52 PM Thomas Stüfe <thomas.stuefe at gmail.com>
> wrote:
>
>> Hi all,
>>
>> May I please have reviews for the following addition to jcmd.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8224600
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8224601
>> webrev:
>>
>> http://cr.openjdk.java.net/~stuefe/webrevs/vm.events/webrev.00/webrev/index.html
>>
>> This adds a new command, "VM.events", which can be used to display VM
>> event
>> logs. Please see linked CSR for details.
>>
>> The CSR itself is not yet approved but already in proposed state.
>>
>> Thanks, Thomas
>>
>