RFR : 8231448: s390 and ppc - replace JVM type comparisons to T_OBJECT and T_ARRAY with call to is_reference_type

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Wed Sep 25 15:18:13 UTC 2019


http://cr.openjdk.java.net/~mbaesken/webrevs/8231448.0/src/hotspot/cpu/ppc/gc/shared/modRefBarrierSetAssembler_ppc.hpp.udiff.html

This seems to just have the copyright change but no other.

Otherwise, looks good.  There were a lot of these!  Thank you for fixing 
this.

Coleen


On 9/25/19 9:08 AM, Baesken, Matthias wrote:
> Hello, please review the following change .
>
> Recently,  https://bugs.openjdk.java.net/browse/JDK-8230505
>
>    replaced  a lot of  JVM conditionals compares against T_OBJECT and T_ARRAY   ( for readability and future extendability )  with a call to
>
> is_reference_type .
>
> However   the change  8230505    did not  change  the calls  in src/hotspot/cpu/ppc   and  src/hotspot/cpu/s390  .
> My change  adjusts the remaining calls  in the  ppc / s390  coding .
>
>
>
> Bug/webrev :
>
> https://bugs.openjdk.java.net/browse/JDK-8231448
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8231448.0/
>
>
> Thanks, Matthias



More information about the hotspot-dev mailing list