RFR : 8231448: s390 and ppc - replace JVM type comparisons to T_OBJECT and T_ARRAY with call to is_reference_type

Lois Foltan lois.foltan at oracle.com
Wed Sep 25 16:28:13 UTC 2019


On 9/25/2019 9:08 AM, Baesken, Matthias wrote:
>
> Hello, please review the following change .
>
> Recently, https://bugs.openjdk.java.net/browse/JDK-8230505
>
>   replaced  a lot of  JVM conditionals compares against T_OBJECT and 
> T_ARRAY   ( for readability and future extendability )  with a call to
>
> is_reference_type .
>
> However   the change 8230505    did not  change  the calls  in 
> src/hotspot/cpu/ppc   and  src/hotspot/cpu/s390  .
>
> My change  adjusts the remaining calls  in the  ppc / s390  coding .
>
> Bug/webrev :
>
> https://bugs.openjdk.java.net/browse/JDK-8231448
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8231448.0/
>

Looks good.  Thank you for making these changes.  One minor comment:

src/hotspot/cpu/s390/c1_LIRAssembler_s390.cpp
- line #1298 there is a space in the assert conditional between "!" and 
"is_reference_type"

I don't need to see another webrev for this.

Thanks,
Lois

> Thanks, Matthias
>



More information about the hotspot-dev mailing list