RFR: 8244801 - Code duplication in ReservedSpace::initialize/ReservedHeapSpace::try_reserve_heap

[Cesar Soares Lucas]

Gentle ping. Can anyone PTAL?


Thanks,
Cesar

________________________________
From: hotspot-dev <hotspot-dev-retn at openjdk.java.net> on behalf of Cesar Soares Lucas <Divino.Cesar at microsoft.com>
Sent: August 6, 2020 2:30 PM
To: hotspot-dev developers <hotspot-dev at openjdk.java.net>
Cc: Brian Stafford <Brian.Stafford at microsoft.com>; Aditya Mandaleeka <adityam at microsoft.com>
Subject: RFR: 8244801 - Code duplication in ReservedSpace::initialize/ReservedHeapSpace::try_reserve_heap


Bug: https://bugs.openjdk.java.net/browse/JDK-8244801
Webrev: https://cr.openjdk.java.net/~adityam/cesar/8244801/0/
Need sponsor: Yes

Can you please review the above linked patch for the mentioned bug?
It's a small change that refactor a portion of duplicated code in `virtualspace.cpp`.

I tried to structure the code so that the new code and the old printed the same
log messages. Please let me know if you want to simplify the method signature
and just hard code the log message. I also tried to come up with a short yet
descriptive name for the method; let me know if you have suggestions on that
as well.


Thanks,
Cesar
Software Engineer - Microsoft