RFR: JDK-8256864: [windows] Improve tracing for mapping errors [v5]

[Thomas Stuefe]

On Wed, 2 Dec 2020 08:50:49 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Feedback Ioi
>
> src/hotspot/os/windows/os_windows.cpp line 3218:
> 
>> 3216:                   (attempt_reserve_memory_at(split_address, size - split) != NULL);
>> 3217:   if (!rc) {
>> 3218:     log_warning(os)("os::split_reserved_memory failed for " RANGE_FORMAT,
> 
> I'm not very much in favor of the closing ")". It will confuse editors trying to match brackets/parenthesis when reading logs. Also I think it is redundant because an inclusive end does not make much sense without specifying how many bytes are included at the end address.
> 
> I see there are already uses of that style so I won't veto if you prefer to keep it.

Okay, I agree. Good point with the editors. Exclusive end is the usual default anyway. 

I'll rework this in a follow up if there is a follow up (there probably will be one).

-------------

PR: https://git.openjdk.java.net/jdk/pull/1390