RFR: JDK-8256864: [windows] Improve tracing for mapping errors [v5]

[Thomas Stuefe]

On Wed, 2 Dec 2020 11:25:13 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Feedback Ioi
>
> src/hotspot/os/windows/os_windows.cpp line 6001:
> 
>> 5999:   const int errval = 0xDE210244;
>> 6000:   for (int i = 0; i < num_words; i++) {
>> 6001:     v[i] = SafeFetch32((int*)p + i, errval);
> 
> I think you will get a sign extend of the loaded 4 bytes to 8 bytes intptr_t on 64 bit. This will be confusing. What about using int[] for v and INTX_FORMAT for printing?
> Alternatively you could leave it like this and use SafeFetchN(). I'd think that would be best.

Oh this is a stupid mistake. I alternated several times between SafeFetchN and SafeFetch32. I must have committed an inconsistent version. Good catch.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1390