RFR: JDK-8256864: [windows] Improve tracing for mapping errors [v5]
Thomas Stuefe
stuefe at openjdk.java.net
Wed Dec 2 12:51:57 UTC 2020
On Wed, 2 Dec 2020 11:38:07 GMT, Richard Reingruber <rrich at openjdk.org> wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Feedback Ioi
>
> test/hotspot/gtest/runtime/test_os.cpp line 523:
>
>> 521:
>> 522: TEST_VM(os, show_mappings_full_range) {
>> 523: test_show_mappings(NULL, 0);
>
> According to hotspot-style.md nullptr should be preferred.
Sigh.
I have an unreasonable dislike against nullptr and the churn that causes (NULL is nullptr anyway post C++11). But I'll be a good boy and change all those :)
-------------
PR: https://git.openjdk.java.net/jdk/pull/1390
More information about the hotspot-dev
mailing list