RFR: JDK-8257588: Make os::_page_sizes a bitmask [v2]

Thomas Stuefe stuefe at openjdk.java.net
Thu Dec 3 13:59:12 UTC 2020


On Thu, 3 Dec 2020 10:20:01 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix 32bit issues
>
> To be really nitpicky: the subject of the PR should be made more specific to mention that the new set is a bitset not just a set. I.e. os::page_sizes has already previously been a set (of integers), so where's the change? :P

Hi Thomas,

thanks again for the review. I hope I addressed all points. I completely removed the comments from the cpp file and corrected them in the hpp file, which removes the need to keep them in sync. And I rather have them in the hpp file, that makes my IDE happy.

Cheers, Thomas

-------------

PR: https://git.openjdk.java.net/jdk/pull/1522


More information about the hotspot-dev mailing list