RFR: JDK-8257588: Make os::_page_sizes a bitmask [v2]

Thu Dec 3 17:57:56 UTC 2020

On Thu, 3 Dec 2020 13:56:03 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> To be really nitpicky: the subject of the PR should be made more specific to mention that the new set is a bitset not just a set. I.e. os::page_sizes has already previously been a set (of integers), so where's the change? :P
>
> Hi Thomas,
> 
> thanks again for the review. I hope I addressed all points. I completely removed the comments from the cpp file and corrected them in the hpp file, which removes the need to keep them in sync. And I rather have them in the hpp file, that makes my IDE happy.
> 
> Cheers, Thomas

+1 on the general thrust of this change. 

I'd be happy to incorporate into https://github.com/openjdk/jdk/pull/1153 & JDK-8256155 [1] if they are approved.

[1] https://bugs.openjdk.java.net/browse/JDK-8256155

-------------

PR: https://git.openjdk.java.net/jdk/pull/1522