RFR: 8257901: ZGC: Take virtual memory usage into account when sizing heap [v2]

Per Liden pliden at openjdk.java.net
Wed Dec 9 12:10:52 UTC 2020


On Wed, 9 Dec 2020 11:29:18 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Per Liden has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review StefanK
>
> Changes requested by tschatzl (Reviewer).

Pushed an update which addresses @tschatzl's comments.

> src/hotspot/share/runtime/arguments.hpp line 368:
> 
>> 366:   // limits the given memory size by the maximum amount of memory this process is
>> 367:   // currently allowed to allocate or reserve.
>> 368:   static julong limit_heap_by_allocatable_memory(julong size);
> 
> Please clarify the documentation of this method also according to the results of this discussion.

Will fix.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1696


More information about the hotspot-dev mailing list