RFR: 8257901: ZGC: Take virtual memory usage into account when sizing heap [v2]

Thomas Schatzl tschatzl at openjdk.java.net
Wed Dec 9 12:10:52 UTC 2020


On Wed, 9 Dec 2020 11:56:42 GMT, Per Liden <pliden at openjdk.org> wrote:

>> src/hotspot/share/runtime/arguments.cpp line 1658:
>> 
>>> 1656: }
>>> 1657: 
>>> 1658: julong Arguments::limit_heap_by_allocatable_memory(julong limit) {
>> 
>> If we are already messing with the name in this change, would it be possible to change return value and parameter to `size_t`? I'm good with moving this change of the parameter types to a different issue, but as mentioned, since we are already changing stuff around here...
>
> I'd prefer to handle that as a separate issue, since such a change would propagate into `os::has_allocatable_memory_limit()` and affect all os:es.

okay.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1696


More information about the hotspot-dev mailing list