RFR: 8258077: Using -Xcheck:jni can lead to a double-free after JDK-8193234

[Mauro Lacy]

On Fri, 11 Dec 2020 11:45:59 GMT, Mauro Lacy <github.com+11656534+maurolacy at openjdk.org> wrote:

>>> I also just re-checked the JDK source and it seems this code also suffers from the COMMIT-only problem:
>>> 
>>> ./jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_crypt.c
>> 
>> I've taken a look and yes, I think you're right. The line
>> `        (*env)->ReleasePrimitiveArrayCritical(env, jOut, outBufP, JNI_COMMIT);`
>> 
>> should probably use `JNI_ABORT` if there's an error, and `0` if it's a normal cleanup.
>> 
>> On second look, `0` looks like the obvious choice. If there's a jump due to an error, `outBufP` will be `NULL`, and the line wouldn't be executed in the first place.
>
> I'll send a PR for that cryptoki fix too, if you like. I'll now try to register into the issue tracker, so I can create a proper issue for it.

Hmmm, crypto stuff. I wonder if... ��

-------------

PR: https://git.openjdk.java.net/jdk/pull/1697