RFR: 8258077: Using -Xcheck:jni can lead to a double-free after JDK-8193234

[Mauro Lacy]

On Fri, 11 Dec 2020 12:07:44 GMT, Mauro Lacy <github.com+11656534+maurolacy at openjdk.org> wrote:

>> I'll send a PR for that cryptoki fix too, if you like. I'll now try to register into the issue tracker, so I can create a proper issue for it.
>
> Hmmm, crypto stuff. I wonder if... ��

> You can't "register" for the OpenJDK JBS, you are only granted write
> access once you have Author status in the OpenJDK project. I will file
> an issue but the security-libs folk will need to decide what to do about it.

OK. Please let me know the issue #, so I can keep an eye on it.

> 
> With regards to an earlier comment regarding the inconsistent behaviour
> - yes this is only a -Xcheck:jni issue because it is only in that case
> that any buffer copying every occurs and so freeing actually does
> something. Otherwise hotspot never copies and the release mode is
> irrelevant with regard to freeing anything.

Fair enough. So, as you said earlier, this is in the end a matter of interpretation of what constitutes correct usage.

> 
> Again I will look further into this, on Monday.

Have a nice weekend.
Mauro

> 
> Cheers,
> David

-------------

PR: https://git.openjdk.java.net/jdk/pull/1697