RFR: 8234930: Use MAP_JIT when allocating pages for code cache on macOS [v7]

Anton Kozlov akozlov at openjdk.java.net
Fri Dec 11 13:32:59 UTC 2020


On Thu, 10 Dec 2020 21:16:36 GMT, Bernhard Urban-Forster <burban at openjdk.org> wrote:

>> Anton Kozlov has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Fix style
>>  - JDK-8234930 v4: Use MAP_JIT when allocating pages for code cache on macOS
>>  - Revert "Separate executable_memory interface"
>>    
>>    This reverts commit 49253d8fe8963ce069f10783dcea5327079ba848.
>
> src/hotspot/os/bsd/os_bsd.cpp line 1937:
> 
>> 1935:   // Bsd mmap allows caller to pass an address as hint; give it a try first,
>> 1936:   // if kernel honors the hint then we can return immediately.
>> 1937:   char * addr = anon_mmap(requested_addr, bytes, false/*executable*/);
> 
> use `!ExecMem`?

Agree, fixed. I've avoided that, as formally it's for `os::` interface layer. But unlikely it's worth even a bit of readability

-------------

PR: https://git.openjdk.java.net/jdk/pull/294


More information about the hotspot-dev mailing list