RFR: 8252148: vmError::controlled_crash should be #ifdef ASSERT and move tests to gtest [v4]

[Coleen Phillimore]

On Mon, 14 Dec 2020 14:11:10 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>>> Hi Thomas, thank you for finding the "last" bug in this. I made the buffer stack allocated and 256. That should be enough and it passes all the gtests. Thanks again.
>> 
>> Thanks Coleen! Looks good now.
>
> Thanks Thomas, Ioi and Gerard. I remerged with JDK-8257229: gtest death tests fail with unrecognized stderr output to make sure they still worked together.

So it turns out that I only tested with linux-x64-debug and not windows and macosx which have slightly different rules for pattern matching.  Some of the patterns in the assert(some expression) failed: message didn't match, so I just added .* to the expected message and that worked better.  Now I've tested them everywhere.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1723