RFR: 8257700: Add logging for sealed classes in JVM_GetPermittedSubclasses [v2]

Harold Seigel hseigel at openjdk.java.net
Wed Dec 16 16:35:14 UTC 2020


On Wed, 16 Dec 2020 00:44:56 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Harold Seigel has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8257700: Add logging for sealed classes in JVM_GetPermittedSubclasses
>
> Hi Harold,
> Looks good. One minor comment below.
> Thanks,
> David

Thanks Lois, Coleen, and David for reviewing this change.  Please review the latest commit that adds the missing ResourceMark and removes the useless logging statement that David mentioned.
Thanks! Harold

> src/hotspot/share/prims/jvm.cpp line 2168:
> 
>> 2166:       // we had invalid entries so we need to compact the array
>> 2167:       log_trace(class, sealed)(" - compacting array from length %d to %d",
>> 2168:                                length, count);
> 
> Not sure this really adds any useful information, but your call.

I agree that it is not useful.  I've removed it.
Thanks, Harold

-------------

PR: https://git.openjdk.java.net/jdk/pull/1780


More information about the hotspot-dev mailing list