[aarch64-port-dev ] RFR: 8248414: AArch64: Remove uses of long and unsigned long ints

[Andrew Dinn]

On 13/07/2020 17:55, Andrew Haley wrote:
> On 13/07/2020 10:48, Andrew Dinn wrote:
>> The patch looks fine except for this one change at assembler_aarch64.hpp:673
>>
>>    void f(unsigned val, int msb) {
>>      current->f(val, msb, msb);
>>    }
>> -  void sf(long val, int msb, int lsb) {
>> +  void sf(uint64_t val, int msb, int lsb) {
>>      current->sf(val, msb, lsb);
>>    }
>>
>> I think val ought to be declared as int64_t.
> 
> Wow! How did I miss that one? Well spotted.
> 
> Is it OK with that change?
Yes, that was the only issue.

regards,


Andrew Dinn
-----------
Red Hat Distinguished Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill