PING? RFR(S): 8239785: Cgroups: Incorrect detection logic on old systems in hotspot

Baesken, Matthias matthias.baesken at sap.com
Thu Mar 12 07:05:16 UTC 2020


Hello Severin, looks okay to me .
Some very minor issues (do not need  to see another webrev)  :

http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8239785/05/webrev/src/hotspot/share/prims/whitebox.cpp.frames.html

CHECK_JNI_EXCEPTION_
might return early without calling  env->ReleaseStringUTFChars (these are in the normal cases called at the end of the method)


http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8239785/05/webrev/src/hotspot/share/prims/whitebox.hpp.frames.html
please adjust Copyright year


http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8239785/05/webrev/src/hotspot/os/linux/cgroupSubsystem_linux.hpp.frames.html

 260 class CgroupInfo : public StackObj {
  ....
 274     CgroupInfo() { // constructor    <---- remove comment



Best regards, Matthias



> 
> I would still need a *R*eviewer for this one. Any takers? Bob has
> already reviewed it.
> 
> http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8239785/05/webrev/
> 
> Thanks,
> Severin
> 



More information about the hotspot-dev mailing list